ruby assignment branch condition size is too high

Red Green Repeat Adventures of a Spec Driven Junkie

Understanding assignment branch condition.

Recently, I integrated Rubocop into my work flow and it’s been very humbling. I feel I’m a great coder with all the specs passing and doing a good job of refactoring, Rubocop always finds something wrong with my code.

I usually go back and make fixes based on Rubocop’s suggestions, but I keep running into the same few issues and solving them isn’t as easy as using: rubocop -a (which auto-corrects all the easy ones!)

The toughest offense for me so far: Assignment Branch Condition

This offense is harder to fix really make me think about my coding style in general. I want to learn more about this offense to help me understand. By understanding, my goals is to not make this offense so often and/or make it easier for me to fix in the future.

What is: ABC?

Rubocop message:

The default is 15 and the first pass of my code is always way past this, probably on average twice this value. So cleaning up my code to meet the default value really takes a lot of work.

From the documentation :

Really Understanding: ABC

Let’s understand what ABC is by checking out the definition of ABC :

Broken down:

• assignments (anything with = )
• branches (anything that jumps out of the current method)
• conditionals (anything that tests logic if , case , unary ? )

SO, to reduce the ABC value, reduce assignments (use less intermediate variables), fewer branches (calling other methods), and conditionals (if/else statements).

Computing ABC

The ABC value is not just a counting of them, but a square root of the sum of their squares. If any one of them getting too high will spike the ABC count.

The Rubocop default for ABC metric is 15. What does 15 really mean?

Well, doing the math, to get an ABC score of 15, a method would have:

• 8 assignments
• 8 conditionals

(Just working backwards from 15*15 => 225; 225/3 => 75; Math.sqrt(75) ~=> 8.66)

Now that I lay it out that way, an ABC value of 15 is very reasonable. Having eight of each for a method is just enough to do a lot of work in a method, but a value of 15 keeps the method from spiraling out of control in assignments, branches, or conditionals.

Whenever I encountered Rubocop’s ‘ABC is too high’ message, I was annoyed with ABC metric because I didn’t understand how it was computed and I couldn’t refactor efficiently to lower the ABC value quickly.

Now that I spent some effort into researching what Assignment Branch Condition really means, I feel better about creating or refactoring code that has a better ABC score.

Search code, repositories, users, issues, pull requests...

Provide feedback.

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly.

To see all available qualifiers, see our documentation .

• Notifications

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement . We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assignment Branch Condition size for hashes #1974

firedev commented Jun 17, 2015

• 👍 1 reaction

jonas054 commented Jun 17, 2015

Sorry, something went wrong.

• 👍 6 reactions

firedev commented Jun 18, 2015

jennwah commented Dec 9, 2020

marcandre commented Dec 9, 2020

No branches or pull requests

DEV Community

Posted on Jun 26, 2020 • Updated on Aug 3, 2020 • Originally published at thedevpost.com

11 Most Asked Questions About RuboCop

RuboCop is a Ruby static code analyzer and code formatter which helps to track errors easily and fix minor code issues during the development process saving your time. It has many advantages and you can learn more about RuboCop on https://docs.rubocop.org/en/stable/ .

Today, we will be talking about the most asked questions about RuboCop.

1. How to check if record exists from controller in Rails

How to test if at least one record exists?

Option 1: Using .exists?

Option 2: Using .present? (or .blank? , the opposite of .present? )

Option 3: Variable assignment in the if statement

This option can be considered a code smell by some linters (RuboCop for example).

Option 3b: Variable assignment

You can also use .find_by_user_id(current_user.id) instead of .where(...).first

Best option:

• If you don’t use the Business object(s): Option 1
• If you need to use the Business object(s): Option 3

Alternative Answer:

In this case, you can use the exists? method provided by ActiveRecord:

2. How to ignore lines with comments?

There is a way to ignore cops on a per-line basis.

There is also a way to do it via the configuration file.

Run rubocop --auto-gen-config and it will generate a file that you can use to disable the offenses.

The command also gives a hint on what to do to load those options.

On a line per line basis, you can enable and disable the cops as well.

You can also do more than one rule at a time in your code.

By using an inline directive, the directive becomes valid only for that line, and it would look like this:

It’s possible to define regex patterns to automatically ignore certain lines in rubocop.yml , so you could choose to ignore all lines starting with a # character:

This could be improved so that “indented” comment lines (i.e. whitespace followed by a # character) is also ignored if that’s what you want.

Note that this doesn’t account for lines of code that end with a comment, though:

3. How to split Ruby regex over multiple lines?

You need to use the /x modifier, which enables free-spacing mode.

Like in this case:

Using %r with the x option is the preferred way to do this.

See this example from the GitHub ruby style guide

4. RuboCop: Line is too long ← How to Ignore?

You can disable a bunch of lines like this:

Or add this to your .rubocop.yml file to increase the max length:

Creating a .rubocop.yml file (keep an eye on the initial . in the filename) in the root of your project, you’ll have a bunch of options:

5. What is meant by ‘Assignment Branch Condition Size too high’ and how to fix it?

Assignment Branch Condition (ABC) size is a measurement of the size of a method. It is essentially determined by counting the number of A ssignments, B ranches, and C onditional statements.

To reduce the ABC score, you could move some of those assignments into before_action calls:

6. How to tell RuboCop to ignore a specific directory or file?

You can add the following to .rubocop.yml:

where the path is relative to .rubocop.yml

From rubocop/default.yml :

7. How to integrate RuboCop with Rake?

The simple answer is just adding this to your Rakefile:

As of version 0.10.0 RuboCop contains a custom rake task that you can use. Just put the following in your Rakefile

Make sure to use upper-case ‘R’ and ‘C’ or you will get a NameError.

8. How to silence RuboCop warning on Assignment Branch Condition?

This is the message for the Metrics/AbcSize cop.

# rubocop:disable Metrics/AbcSize

On your RuboCop config

9. How to disable frozen string literal comment checking?

Add the following to your .rubocop.yml :

10. How to pass &:key as an argument to map instead of a block with Ruby?

Pass &:key as an argument to map instead of a block.

11. How to fix "SublimeLinter-RuboCop not running even when enabled and RuboCop in the path"?

First, specify the right path for you ruby env in Packages/User/SublimeLinter.sublime-settings as this:

After that close sublime completely and reopen it.

In Conclusion

These are the most asked questions about the RuboCop. If you have any suggestions or any confusion, please comment below. If you need any help, we will be glad to help you.

We, at Truemark , provide services like web and mobile app development, digital marketing, and website development. So, if you need any help and want to work with us, please feel free to contact us.

Hope this article helped you.

Original Source: DevPostbyTruemark

Top comments (0)

Templates let you quickly answer FAQs or store snippets for re-use.

Are you sure you want to hide this comment? It will become hidden in your post, but will still be visible via the comment's permalink .

Hide child comments as well

For further actions, you may consider blocking this person and/or reporting abuse

Kong plugin development with breakpoint debugging

Mehul Sharma - Apr 14

DHCP Scope Creation and DHCP Option Management

sajjad hussain - Apr 14

GrayKevin - Apr 14

การแสดง Multiple Linear Regression เป็นกราฟ 3 มิติ โดยใช้ Python

Visit Manomaivisit - Apr 14

We're a place where coders share, stay up-to-date and grow their careers.

More than 3 years have passed since last update.

RuboCopでこんなエラーが出た。Assignment Branch Condition size for search is too high.

コミットをする前にこんなエラーが出た。 調べてみると、なげーよ、幅取りすぎだろみたいなエラーらしい。

RuboCopとは。簡単に

RuboCopのGithub https://github.com/rubocop-hq/rubocop/tree/v0.28.0

このRubCopはコードを検査してくれるものらしくて、コードが長いとか、インデントが変だとかいろんなことを教えてくれる。勝手に直してくれる（不自然なインデントを修正）ときもあれば、警告文だけだして、自分でどうにかしてくれみたいな時もある。ただ、このRuboCopからの指摘も全てが正しい訳ではないっぽい。

　今回のエラーに関して

最初に述べたように、なげーよ的な意味らしい。

実際に指摘を受けたコード

自分でも書いていて、長いなと思った。縦に長い。ただ、今の知識ではどうやってコードをより簡潔なものにすればいいか思いつかなかった。だれか教えてください。

それで結局どうしたか・・・

.rubocop.yml RuboCopの設定を変更した。 エラー文を見てみると、、、、

[<10, 21, 5> 23.79/20] この部分が、点数を表しているっぽい。これでみると、これだと『MAXスコアが20なのにお前のは23.79だよ』ってことらしく、これをどうにかするしかないと思った。

それで、.rubocop.yml内にある設定を変更した。

どう変更したかというと、、、

このMaxの部分を 25に設定を変更した。そしてコミットすると、RubCopからの指摘を受けずにすんだ。

設定変えられるのかー程度に、この記事では感じていただければ、幸いです。

Register as a new user and use Qiita more conveniently

• You get articles that match your needs
• You can efficiently read back useful information
• You can use dark theme